[PATCH RFC] scmutil: add a simple key-value file helper

Augie Fackler raf at durin42.com
Mon Dec 5 17:07:47 EST 2016


> On Dec 5, 2016, at 16:54, Jun Wu <quark at fb.com> wrote:
> 
>> +                e = _("Invalid value in a simple key-value file")
>> +                raise self.InvalidValueInFileException(e)
> 
> These sound like a programmer error. Maybe just raise RuntimeError.

I'm not comfortable with that, FYI. RuntimeError IMO should be reserved for errors in the Python runtime itself, not run-time errors caused by programmer error.


More information about the Mercurial-devel mailing list