[PATCH RFC v7] scmutil: add a simple key-value file helper

Jun Wu quark at fb.com
Tue Dec 6 16:53:13 EST 2016


Excerpts from Kostia Balytskyi's message of 2016-12-06 13:41:07 -0800:
>  class CorruptedState(Exception):
>      """error raised when a command is not able to read its state from file"""
> +
> +class MissingRequiredKeyInFileException(Exception):
> +    """error raised when simple key-value file misses a required key"""

I still think "CorruptedState" is better. It fits the use-case, is short and
concise. 6-word exception sounds strange to me, partially because everything
else in error.py is at most 4 words. If we have to use a new exception,
maybe just "MissingRequiredKey", or just "KeyError".


More information about the Mercurial-devel mailing list