[PATCH RFC v7] scmutil: add a simple key-value file helper
kobalyts at outlook.com
Tue Dec 6 17:04:38 EST 2016
On 12/6/16 9:53 PM, Jun Wu wrote:
> Excerpts from Kostia Balytskyi's message of 2016-12-06 13:41:07 -0800:
>> class CorruptedState(Exception):
>> """error raised when a command is not able to read its state from file"""
>> +class MissingRequiredKeyInFileException(Exception):
>> + """error raised when simple key-value file misses a required key"""
> I still think "CorruptedState" is better. It fits the use-case, is short and
> concise. 6-word exception sounds strange to me, partially because everything
> else in error.py is at most 4 words. If we have to use a new exception,
> maybe just "MissingRequiredKey", or just "KeyError".
I agree that the name I chose is too long. But CorruptedState is a
significantly different thing than missing key and gut feeling tells me
it should sometimes be treated differently. I can't think of an example
right now though.
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
More information about the Mercurial-devel