[PATCH] push: add a message when pushing phases but not changes

Martin von Zweigbergk martinvonz at google.com
Tue Dec 6 17:56:43 EST 2016


On Tue, Dec 6, 2016 at 2:48 PM, Jeremy Wall <jeremy at marzhillstudios.com> wrote:
>
>
> On Tue, Dec 6, 2016 at 1:17 PM, Augie Fackler <raf at durin42.com> wrote:
>>
>> On Tue, Dec 6, 2016 at 2:16 PM, Jeremy Wall <jeremy at marzhillstudios.com>
>> wrote:
>> > Should the BC changes be in this change or should they be separate
>> > changes?
>>
>> I think I'd make it a separate change for clarity.
>>
>> >
>> > On Tue, Dec 6, 2016 at 11:44 AM, Augie Fackler <raf at durin42.com> wrote:
>> >>
>> >> On Tue, Dec 6, 2016 at 12:38 PM, Martin von Zweigbergk via
>> >> Mercurial-devel <mercurial-devel at mercurial-scm.org> wrote:
>> >> > On Tue, Dec 6, 2016 at 9:29 AM, Mateusz Kwapich <mitrandir at fb.com>
>> >> > wrote:
>> >> >> Excerpts from Jeremy Wall (zaphar)'s message of 2016-12-02 13:12:20
>> >> >> -0600:
>> >> >>> diff -r 9e29d4e4e08b -r 9cb1540e417d tests/test-phases-exchange.t
>> >> >>> --- a/tests/test-phases-exchange.t    Tue Nov 29 04:11:05 2016
>> >> >>> -0800
>> >> >>> +++ b/tests/test-phases-exchange.t    Wed Nov 30 15:55:42 2016
>> >> >>> -0600
>> >> >>> @@ -384,7 +384,7 @@
>> >> >>>    $ hg push ../alpha # from nu
>> >> >>>    pushing to ../alpha
>> >> >>>    searching for changes
>> >> >>> -  no changes found
>> >> >>> +  sending phase public for 145e75495359
>> >> >>>    [1]
>> >> >>
>> >> >> I suppose now, that we are addmitting that there was something to
>> >> >> push
>> >> >> we should change the RC to 0. Question to others: would such change
>> >> >> be
>> >> >> considered a BC-breakage or a fix?
>> >> >
>> >> > Good point! The exit code is misleading, so I'd definitely say that's
>> >> > a fix that should be done regardless of changing the "no changes
>> >> > found" message.
>> >>
>> >>
>> >> My sense is that we should do both, but not change the exit status
>> >> until we're printing some text that explains why the exit status is
>> >> zero. I view this as a bugfix that we should tag (BC).
>
>
> Okay so next steps. Do I amend this commit with the modifications and then
> re-email it? or do I create a new commit with the new changes and email
> that?

Amend, so we get a full patch that applies to the default branch in
the central repo. When you email, please add --flag=V2 to indicate
that the new patch is the second version of the patch.

>
>
> --
> Jeremy Wall
> http://jeremy.marzhillstudios.com
> Jeremy at marzhillstudios.com


More information about the Mercurial-devel mailing list