[PATCH] parsers: use buffer to store revlog index

Yuya Nishihara yuya at tcha.org
Tue Dec 13 09:04:16 EST 2016


On Mon, 12 Dec 2016 22:11:02 -0800, Gregory Szorc wrote:
> This patch LGTM. Only thing I would have done differently is store a
> Py_buffer* instead of a Py_buffer to ensure alignment of indexObject struct
> entries. But I don't think this struct is that performance sensitive to
> care. Feel free to address in a follow-up if you disagree.

Just curious. What kind of alignment issue would be solved by not storing
a Py_buffer struct?


More information about the Mercurial-devel mailing list