[PATCH 3 of 8 v4] convert: remove unused dictionaries

David Soria Parra davidsp at fb.com
Wed Dec 14 04:46:39 EST 2016


# HG changeset patch
# User David Soria Parra <davidsp at fb.com>
# Date 1481708717 28800
#      Wed Dec 14 01:45:17 2016 -0800
# Node ID 34621390d72ed1e23f30e6c8d0233d46e9d40ef2
# Parent  09e574c75df2e3547a40f9d9b13464c63235136c
convert: remove unused dictionaries

self.parent, self.lastbranch and self.tags have never been used.

diff --git a/hgext/convert/p4.py b/hgext/convert/p4.py
--- a/hgext/convert/p4.py
+++ b/hgext/convert/p4.py
@@ -60,9 +60,6 @@
         self.changeset = {}
         self.files = {}
         self.copies = {}
-        self.tags = {}
-        self.lastbranch = {}
-        self.parent = {}
         self.encoding = self.ui.config('convert', 'p4.encoding',
                                        default=convcmd.orig_encoding)
         self.depotname = {}           # mapping from local name to depot name
@@ -292,7 +289,7 @@
         return self.changeset[rev]
 
     def gettags(self):
-        return self.tags
+        return {}
 
     def getchangedfiles(self, rev, i):
         return sorted([x[0] for x in self.files[rev]])


More information about the Mercurial-devel mailing list