Constant naming convention
pierre-yves.david at ens-lyon.org
Thu Dec 15 15:40:39 EST 2016
On 12/13/2016 06:03 PM, Kevin Bullock wrote:
>> On Dec 13, 2016, at 10:29, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>> On 12/12/2016 04:12 PM, Augie Fackler wrote:
>>> Can we just align with prevailing Python style here and start using
>>> all caps for constants? This comes up roughly monthly, and I think
>>> it'd be a good clarity win.
>> As much as there is many thing in our current coding still, it is our current coding style and our codebase is consistent with it for the very vast majority. As stated previously, my current stance is that we should refrain for changing this category for policy for about one year after Matt stepped away. So I would like us to keep to lower case constants for now.
>> At the 4.4 sprint, I'll be very happy to have a large discussion about our style (and very happy to us CAPS for constant at that time).
> Ehh? I don't recall us ever having discussed a one-year moratorium on style changes, and I don't see a reason we would need to wait until the sprint to decide a matter of style.
My "moratorium" position is not especially targeted at "matter of style"
but more on "policy Matt decided". They have not been a discussion on
that topic (in general we did not discussed too much things about the
transition). But that is the position I gave to the multiple people who
asked me thing around "Now that Matt stepped down can we change X?", I
don't have exact memory but this probably include at least Laurent,
Ryan, Greg (most certainly Greg ;-)) and Augie (who apparently have no
memory of it).
So, let's clarify my position here.
Over the 11 years of his maintainership, Matt had to make decisions on
many matters. Multiple of them were controversial, I agree with some of
them and disagree with some others, but that is no important here. Their
was decision to make and Matt mad decisions who worked out and helped
the project to move forward for the past 11 years.
The last thing I want is thundering herds of questions being re-open for
discussion. Most of these decisions have been working fine for about 11
years, so there is no urgency to re-open the topic. If we roll 11 years
with them we can roll 12 years with them. In the mean time we have
enough on our plate with the rest of the transition, to keep use
busy in the mean time.
In addition, Matt has done the hard move to hand over his project to a
group of people, trusting them to keep his "legacy" moving, if the first
things we do it to overturn all his decisions, I would find it quite
disrespectful. So yes, Matt decisions will eventually up to discussion,
but that can wait for a bit and be done gradually after that.
So, to sum up, my stance is "Let us not revisit decision made by Matt
for a while". Of course they might be case were we could make an
exception if it is really worth it. Code style does not seems to be high
profile enough for that (and is a lot of work to adjust).
> That being said, the prevailing (though by no means universal) style does seem to be lowercase for constants. If we were to change those to all-caps, it would mean a fair amount of churn. If we were starting from scratch I'd say we should unequivocally use all-caps; since that's not the case I'm about -0 on the idea.
More information about the Mercurial-devel