[PATCH] tests: exclude bundled pywatchman from check-code test

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Dec 21 06:40:49 EST 2016



On 12/21/2016 05:29 AM, David Soria Parra wrote:
> # HG changeset patch
> # User David Soria Parra <davidsp at fb.com>
> # Date 1482294521 28800
> #      Tue Dec 20 20:28:41 2016 -0800
> # Node ID 26a5b7f91ec50d20782816b83841bd8087478eb0
> # Parent  b090cdf0e161af0ac6768cb404cc0e51bb0baf00
> tests: exclude bundled pywatchman from check-code test
>
> pywatchman is imported from upstream and therefore fails to pass
> linting. We have added 'no-check-code' manually to every file in the
> past. This is cumbersome and modifies upstream sources.

Sure, pushed, thanks.

> diff --git a/tests/test-check-code.t b/tests/test-check-code.t
> --- a/tests/test-check-code.t
> +++ b/tests/test-check-code.t
> @@ -7,13 +7,8 @@
>  New errors are not allowed. Warnings are strongly discouraged.
>  (The writing "no-che?k-code" is for not skipping this file when checking.)
>
> -  $ hg locate -X contrib/python-zstandard | sed 's-\\-/-g' |
> -  >   xargs "$check_code" --warnings --per-file=0 || false
> -  Skipping hgext/fsmonitor/pywatchman/__init__.py it has no-che?k-code (glob)
> -  Skipping hgext/fsmonitor/pywatchman/bser.c it has no-che?k-code (glob)
> -  Skipping hgext/fsmonitor/pywatchman/capabilities.py it has no-che?k-code (glob)
> -  Skipping hgext/fsmonitor/pywatchman/msc_stdint.h it has no-che?k-code (glob)
> -  Skipping hgext/fsmonitor/pywatchman/pybser.py it has no-che?k-code (glob)
> +  $ hg locate -X contrib/python-zstandard -X hgext/fsmonitor/pywatchman |
> +  > sed 's-\\-/-g' | xargs "$check_code" --warnings --per-file=0 || false
>    Skipping i18n/polib.py it has no-che?k-code (glob)
>    Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)
>    Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list