[PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

Augie Fackler raf at durin42.com
Fri Dec 30 10:38:18 EST 2016


> On Dec 30, 2016, at 5:25 AM, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> 
>> This patch adds a new 'rawrevision()' method setting the 'raw' argument to True
>> in the revlog.revision() call that is used to differentiate changegroup
>> generation and debugdata related calls to revision() from regular read accesses.
> 
> I don't get that part. it seems like 'rawrevision(…)' is just 'revision(…, raw=True)' so I do not understant why we need a new method. Can't we just call 'revision(…, raw=True)' directly. Am I missing something? Otherwise, we should just drop that method.

I believe it’s so that we can have extensions hook into either reading of raw revisions or non-raw revisions. In a perfect world, revision() wouldn’t even take a raw= keyword, but I’ve lost too much context this week to help without rereading the whole patch (which I don’t have time for right now.)


More information about the Mercurial-devel mailing list