[PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

Augie Fackler raf at durin42.com
Fri Dec 30 12:09:00 EST 2016


> On Dec 30, 2016, at 12:04 PM, Rémi Chaintron <remi.chaintron at gmail.com> wrote:
> 
> Following discussion with marmoute on IRC, I'll drop the rawrevision() method for now.

OOC, what’s the rationale for preferring the boolean parameter instead of making the code structure more self-documenting? I legitimately don’t see why the parameter version is preferable design-wise.

Thanks!

(Remi, don’t let my discussion of code organization preferences slow down your patch - do whatever Pierre-Yves is wanting so you can keep making progress.)


More information about the Mercurial-devel mailing list