[PATCH 1 of 4] check-code: allow "grep pattern filename-containing-dash-a"

Martin von Zweigbergk martinvonz at google.com
Wed Feb 3 01:01:54 EST 2016

# HG changeset patch
# User Martin von Zweigbergk <martinvonz at google.com>
# Date 1454476804 28800
#      Tue Feb 02 21:20:04 2016 -0800
# Node ID de3954c992eda0c34742124dc96f589dbf50787e
# Parent  8e79ad2da8a69735488402fd018dd82bc1eb9309
check-code: allow "grep pattern filename-containing-dash-a"

We're trying to forbid "grep -a" and unintentionally complained even
if the "-a" was part of the filename. Requiring a space before "-a" to
match is probably good enough.

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -90,7 +90,7 @@
     (r'pushd|popd', "don't use 'pushd' or 'popd', use 'cd'"),
     (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"),
     (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
-    (r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"),
+    (r'(?<!hg )grep.* -a', "don't use 'grep -a', use in-line python"),
     (r'sed.*-i', "don't use 'sed -i', use a temporary file"),
     (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),
     (r'echo -n', "don't use 'echo -n', use printf"),

More information about the Mercurial-devel mailing list