[PATCH 1 of 7] blackbox: log working directory version

Durham Goode durham at fb.com
Wed Feb 3 17:08:36 EST 2016


On 2/3/16 2:06 PM, timeless wrote:
> Durham Goode wrote:
>> Does this mean every hg command will be running 'hg status' under the hood
>> to populate the '+'?  And is it happening for every ui.log() as well, when
>> the blackbox is enabled?
>>
>> If that's the case, that would introduce some major perf issues I think.
> Yes. It's only doing the `+` stuff because I was asked to do it.
> There's /some/ value in knowing dirty state, but perhaps a better
> approach would be for blackbox to monitor status and log when
> something reports dirty state instead of checking constantly.
>
> I'm not wed to the `+`.
> I'd rather get as much of this series in as possible, than get stuck
> on any particular corners.
K, I'd either drop the dirty stuff, or put it behind an opt-in config 
flag.  I don't think anyone will ever want it on by default without 
opt'ing in.


More information about the Mercurial-devel mailing list