[PATCH] verify: include changesets and manifests in "total revisions"

Sean Farley sean at farley.io
Wed Feb 3 20:37:32 EST 2016


Martin von Zweigbergk <martinvonz at google.com> writes:

> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1454524673 28800
> #      Wed Feb 03 10:37:53 2016 -0800
> # Node ID c011b7551169ebc5546477f45587cc0de9e8be99
> # Parent  8e79ad2da8a69735488402fd018dd82bc1eb9309
> verify: include changesets and manifests in "total revisions"
>
> The output from "hg verify" includes the number of "total revisions",
> which I would assume should include the total revisions in the
> changelog, manifest log and all filelogs. However, it's only the total
> number of revisions in filelogs. It turns out that when it was
> initially added in d7e859cf2f1b (merge: add count of new manifests,
> files, and revisions, 2005-05-29), it did include the revisions in the
> changelog and manifest log, but then it regressed in the very next
> commit, 5d8553352d2e (Changes to network protocol, 2005-05-30).
>
> Fix by making _verifychangelog() and _verifymanifest() return the
> number of revisions. It would be easier to just re-measure the length
> of the revlogs in verify(), but since I will soon be making
> _verifymanifest() verify directory manifests, it will make more sense
> for that method to return the number of revisions. And then
> _verifychangelog() should return its count for consistency.

This seems to make sense to me but I will defer to others that know more
about this code.


More information about the Mercurial-devel mailing list