[PATCH] verify: include changesets and manifests in "total revisions"

[Martin von Zweigbergk]

On Thu, Feb 4, 2016 at 7:05 AM Yuya Nishihara <yuya at tcha.org> wrote:

> On Wed, 03 Feb 2016 13:17:21 -0600, Martin von Zweigbergk wrote:
> > # HG changeset patch
> > # User Martin von Zweigbergk <martinvonz at google.com>
> > # Date 1454524673 28800
> > #      Wed Feb 03 10:37:53 2016 -0800
> > # Node ID c011b7551169ebc5546477f45587cc0de9e8be99
> > # Parent  8e79ad2da8a69735488402fd018dd82bc1eb9309
> > verify: include changesets and manifests in "total revisions"
> >
> > The output from "hg verify" includes the number of "total revisions",
> > which I would assume should include the total revisions in the
> > changelog, manifest log and all filelogs. However, it's only the total
> > number of revisions in filelogs. It turns out that when it was
> > initially added in d7e859cf2f1b (merge: add count of new manifests,
> > files, and revisions, 2005-05-29), it did include the revisions in the
> > changelog and manifest log, but then it regressed in the very next
> > commit, 5d8553352d2e (Changes to network protocol, 2005-05-30).
>
> I think this change is fine, but the original "verify" seems to count the
> number of file revisions.
>
> https://selenic.com/repo/hg/rev/9117c6561b0b#l3.177


Huh, you're right, of course. Thanks for checking. I retraced my steps to
see where I got lost. It turns out "hg blame -r 81d7db1aa0fb
mercurial/localrepo.py" has two occurrences of "changesets = files =
revisions = 0". That find also made me realize that we use the same way of
counting revisions pulled in ("added 2 changesets with 14 changes to 11
files"), so if we want to count all revisions, we should update that too.
We should also use the same terminology in both places, perhaps by
continuing the work started in f05deda58457 (Make pull count jargon less
confusing, 2005-07-25).

I don't know prehistory of this revision.
>

:-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160204/e7070841/attachment.html>