[PATCH] ui: add new config flag for interface selection

Laurent Charignon lcharignon at fb.com
Thu Feb 4 13:28:35 EST 2016


From the problem that Pierre-Yves mentioned, we have resolved 2 issues out of 3:

1) In what section to put this code.

=> RESOLVED: We are going to stick to what I sent in the patch, i.e. ui.interface.XYZ

2) What should the config value be

=>NOT RESOLVED: Augie thinks that we won't have a second curses interface and wants to simplify the option choice accordingly.
Pierre-Yves disagrees and prefers to keep a more complex but more flexible option.
I am personally fine with any choice, but I prefer Pierre-Yves' idea as it is more extensible, let's be optimistic, we could have another curses interface one day!


3) What happen when the specified value is unknown.

=> RESOLVED: Nobody feels strongly about one side or the other, so let's go with a warning.
Also I don't expect automation to play with the value of these config options, it wouldn't be very wise to try to select hunk programmatically with crecord.

I am sending a new patch following what I said above and Pierre-Yves' proposal for 2.
Let's move the discussion there.

Thanks,

Laurent

> On Jan 18, 2016, at 6:03 AM, Yuya Nishihara <yuya at tcha.org> wrote:
> 
> On Sun, 17 Jan 2016 10:11:53 -0800, Pierre-Yves David wrote:
>>> I was thinking a separate section because it would be simpler to disable them
>>> if HGPLAIN specified.
>>> 
>>>        if self.plain():
>>>             for k, v in cfg.items('ui-interface-section'):
>>>                 del cfg['ui-interface-section'][k]
>>>             # or implement config.__delitem__() to write
>>>             # del cfg['ui-interface-section']
>>> 
>>> But anyway, it isn't a big deal, we can iterate each key under 'ui' and test
>>> if it starts with 'interface' or 'interface.'.
>> 
>> I'm reading your reply as "being okay with using ui.interface" am I right?
> 
> Yes, that's fine.
> 
> (Please don't forget to disable ui.interface* if HGPLAIN is specified.)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list