[PATCH 2 of 5 v3] treemanifests: prevent creating non-fncache repos

[Martin von Zweigbergk]

On Fri, Feb 5, 2016 at 9:41 AM Durham Goode <durham at fb.com> wrote:

> On 2/4/16 4:51 PM, Martin von Zweigbergk wrote:
> > # HG changeset patch
> > # User Martin von Zweigbergk <martinvonz at google.com>
> > # Date 1454474807 28800
> > #      Tue Feb 02 20:46:47 2016 -0800
> > # Node ID ce19ab75f32b18ee4ddc251f3f841c23988a63d2
> > # Parent  b028f259a33ba2e4182cfa866f80af38ac6fe62a
> > treemanifests: prevent creating non-fncache repos
> >
> > In order to make local and streaming (--uncompressed) clones work with
> > treemanifests, we will have to update the store (store.py). To save us
> > from needing support for treemanifests even in the ancient bundles,
> > let's prevent creation av repos with 'treemanifest' requirement and
> > not 'fncache' requirement set. The 'treemanifest' requirement can be
> > turned on in two ways:
> >
> >   1. If config option 'experimental.treemanifest' is on at repo
> >     creation time.
> >
> >   2. When pulling in a changegroup part with a 'treemanifest' parameter
> >      set.
> >
> > For 1), we simply add the 'fncache' requirement as well, ignoring
> > "--config format.usefncache=False" from the user. For 2), the repo
> > already exists, so it's too late to turn 'fncache' on. Instead, we
> > report an error to the user.
> >
> We actually have the fncache disabled on our servers because it is so
> large that reading and writing the file is a performance issue. So
> ideally treemanifests would work without it (otherwise we're just going
> to have to fix this before we can ship it internally).
>

Okay, will work on a v4. Thanks for noticing.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160205/7d087698/attachment.html>