[PATCH] filectx: replace use of _filerev with _filenode

Sean Farley sean at farley.io
Mon Feb 8 17:55:47 EST 2016


Durham Goode <durham at fb.com> writes:

> # HG changeset patch
> # User Durham Goode <durham at fb.com>
> # Date 1454969831 28800
> #      Mon Feb 08 14:17:11 2016 -0800
> # Node ID b8f90918f80e13e468d0fa22ca2f678896223cbd
> # Parent  01a5143cd25f285f8c745a92986cd7186bb32c90
> filectx: replace use of _filerev with _filenode
>
> _filerev depends on the filelog implementation using revlogs and linkrevs.
> Alternative implementations, like remotefilelog, do not have rev numbers, so
> this call fails. Replacing it with _filenode means it doesn't rely on rev
> numbers, and doesn't cost anything extra, since _filerev is using _filenode
> under the hood anyway.

Seems fine to me.


More information about the Mercurial-devel mailing list