[PATCH] bookmarks: avoid creating a nested repository during testing
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Fri Feb 12 09:10:15 EST 2016
On 02/12/2016 01:59 PM, Martijn Pieters wrote:
> On Fri, Feb 12, 2016 at 1:53 PM, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
>> While I entirely support detaching bookmark test from repository nesting
>> tests, I would like to make sure we still testing repository nesting
>> properly and that watchman is still failing a test somewhere for the very
>> reason you are working around here.
>>
>> Can you either find and point at such test case (in the description of a V2)
>> or introduce one (in a V2 series) ?
>
> hgwatchman currently has no tests of their own; I'm writing a series
> of tests and will make sure I'll include expected failures. That's
> very much outside the scope of *this* patch however.
As said in person, I just want to make sure we are not loosing test
coverage by updating this test. Apparently test-nested-repo.t is also
covering this behavior (well, hgwatchman misbehavior). So I would like
you to update the patch description to point at this fact "double
coverage with test-nested-repo" and send it as a V2 that I will happily
take :)
Cheers,
--
Pierre-Yves David
More information about the Mercurial-devel
mailing list