[PATCH 3 of 5] histedit: break _histedit function into smaller pieces (add _getgoal and _validateargs)

[Pierre-Yves David]

On 02/13/2016 07:44 PM, Pierre-Yves David wrote:
>
>
> On 02/02/2016 07:28 PM, Kostia Balytskyi wrote:
>> # HG changeset patch
>> # User Kostia Balytskyi <ikostia at fb.com>
>> # Date 1454345734 0
>> #      Mon Feb 01 16:55:34 2016 +0000
>> # Branch stable
>> # Node ID 4118b5fdc4a1fc9acc4a8f6580edb7ea6dd2adcf
>> # Parent  2728f0ff3f167be2489fd8857fac536a4d937883
>> histedit: break _histedit function into smaller pieces (add _getgoal
>> and _validateargs)
>
> Thank for the slicing of thi gigantic function into multiple smaller
> one. That was long overdue.
>
> However, we are quite strict about keeping large code movement free of
> other change to reduce the chance of hard to track bug introduction and
> to reduce the chance that the code move get rejected because of the
> changes.
>
> In this patch you are introducing a new GOAL "enum" that should go in a
> later series.

patch 1, 2 and 4 are not affected by this enum. I've pushed them to the 
clowncopter.

Cheers,

-- 
Pierre-Yves David

PS: (please still send a V2 for 3 and 5 without the enum and with the 
updated description requested by Augie)