[PATCH 4 of 5] chgserver: add umask method

Jun Wu quark at fb.com
Tue Feb 16 09:55:15 EST 2016


On 02/16/2016 02:21 PM, Yuya Nishihara wrote:
> Command-server protocol is binary. Can it be a 32bit unsigned integer
> in network byteorder?

Was a bit worried about sizeof(mode_t) > 4 on some strange OSes but
it looks pretty unlikely. Will include the change in V2.

> And I think 'setumask' is better name as this 'umask' command doesn't
> return the old value.

I think you mean 'getumask'. It is sadly a GNU extension. umask is more
portable.


More information about the Mercurial-devel mailing list