[PATCH 2 of 3] cmdutil: do not unlink lockpath if it's empty

Jun Wu quark at fb.com
Wed Feb 17 11:23:13 EST 2016


On 02/17/2016 03:52 PM, Yuya Nishihara wrote:
> If lockpath (= opts['daemon_pipefds']) is empty, the whole "if
> opts['daemon_pipefds']" block would be skipped.

Didn't notice how opts work. Then the patch is totally wrong.

> Also, as I said before, --daemon-pipe-fds is the internal option. It
> isn't supposed to be specified by external tools. I don't want to
> introduce an unclear change in the core just for supporting chg.

Since it's internal option, I guess we can rename it freely. The name
"pipe-fd" does not reflect what it is doing now. I do want to split
it into "--daemon-mode" and "--daemon-unlink".


More information about the Mercurial-devel mailing list