[PATCH 3 of 3 V2] chg: pass sensitive command line flags to server

Jun Wu quark at fb.com
Wed Feb 17 17:39:26 EST 2016


On 02/17/2016 08:04 PM, timeless wrote:
> Do you want to pass Debug as well? (Debugger can't be easily)

I don't see it necessary for now. If the code runs normally without
issue, then dispatch will be called by commandserver runcommand with
--debug set. Therefore, command depending on --debug is expected to work
well.

--traceback is special since it will cover some code path before hitting
runcommand. A quick search indicates --debug does not affect the
behavior here.

Anyway, the current ui/config code may need some refactoring to make
things more clear (and chg to be more confident). I'm thinking about
this recently and may write a proposal.


More information about the Mercurial-devel mailing list