[PATCH] test: remove dependency on $PYTHONDIR

timeless timeless at gmail.com
Thu Feb 18 23:07:37 EST 2016


Durham Goode wrote:
> I understand the frustration with fixing glob'd lines, but won't these lines
> need manual fixing even with the $PYTHONDIR change? Because the line number
> is glob'd?


>
> Perhaps, instead of hard coding $PYTHONDIR in the tests, you could
> post-process the -i output, and replace any occurrence of the python
> directory path with a glob and add (glob) at the end of the line. That way
> -i works correctly for anyone with a standard python path set up, and we're
> not hard coding expected python paths in the tests.  From looking at the
> code in run-tests.py:addOutputMismatch(), it might be as simple as a
> regex.replace().
>
> Such post processing logic could also eventually recognize "file.py:LINE"
> patterns and auto-glob the LINE as well.


More information about the Mercurial-devel mailing list