[PATCH 3 of 3 V2] chg: pass sensitive command line flags to server

Jun Wu quark at fb.com
Fri Feb 19 09:14:48 EST 2016


Thanks and sorry for the spell mistakes etc. I'll be more careful when
sending remaining patches.

On 02/19/2016 02:00 PM, Yuya Nishihara wrote:
> s/sensetive/sensitive/g :)
Time to setup a (special?) vim spell checker!

> Hmm, it will actually reallocate 'args' buffer incrementally. Though
> glibc malloc() seems to reuse old 'args' location as there are no
> other malloc/free, I don't think it is a good design.
I was aware of this issue and the glibc behavior. Considered there are
not many flags in most cases, I think it's okay to not have an
additional pass calculating the length.


More information about the Mercurial-devel mailing list