[PATCH 3 of 3] graphmod: use different styles for different edge types

[Tim Delaney]

On 20 February 2016 at 06:44, Sean Farley <sean at farley.io> wrote:

>
> Martijn Pieters <mj at zopatista.com> writes:
>
> > # HG changeset patch
> > # User Martijn Pieters <mjpieters at fb.com>
> > # Date 1455902539 0
> > #      Fri Feb 19 17:22:19 2016 +0000
> > # Node ID 1bd1587ea3d6f5a07e0ca6f7498515bc6a96a07a
> > # Parent  3f78472bf42c4d9a6243e5bd9ee5729a32f4cdff
> > graphmod: use different styles for different edge types
> >
> > Rather than always draw edges as solid lines, use dotted lines for edges
> that
> > do not connect to a parent, and dashed lines when connecting to a
> grandparent
> > (implying missing nodes in between).
> >
> > This is part of the work towards moving smartlog upstream; currently
> smartlog
> > injects extra nodes into the graph to indicate grandparent relationships
> (nodes
> > elided).
>
> This took me a little while to review but seems to work for me. I like
> the direction!


I'm not sure about using the fullstop/period - it doesn't look like a path
to me. I experimented with a few things, and to me using an exclamation
mark for grandparent and colon for non-parent looks best whilst still being
visually distinctive.

 o    changeset:   32:d06dffa21a31
 |\   parent:      27:886ed638191b
 | :  parent:      31:621d83e11f67
 | :  user:        test
 | :  date:        Thu Jan 01 00:00:32 1970  0000
 | :  summary:     (32) expand
 | :
 o :  changeset:   31:621d83e11f67
 |\:  parent:      21:d42a756af44d
 | :  parent:      30:6e11cd4b648f
 | :  user:        test
 | :  date:        Thu Jan 01 00:00:31 1970  0000
 | :  summary:     (31) expand
 | :
 o :    changeset:   30:6e11cd4b648f
 |\ \   parent:      28:44ecd0b9ae99
 | ! :  parent:      29:cd9bb2be7593
 | ! :  user:        test
 | ! :  date:        Thu Jan 01 00:00:30 1970  0000
 | ! :  summary:     (30) expand
 | ! :
 o ! :    changeset:   28:44ecd0b9ae99
 |\ \ \   parent:      1:6db2ef61d156
 | ! ! :  parent:      26:7f25b6c2f0b9
 | ! ! :  user:        test
 | ! ! :  date:        Thu Jan 01 00:00:28 1970  0000
 | ! ! :  summary:     (28) merge zero known
 | ! ! :
 o ! ! :    changeset:   26:7f25b6c2f0b9
 |\ \ \ \   parent:      18:1aa84d96232a
 | | ! ! :  parent:      25:91da8ed57247
 | | ! ! :  user:        test
 | | ! ! :  date:        Thu Jan 01 00:00:26 1970  0000
 | | ! ! :  summary:     (26) merge one known; far right
 | | ! ! :

Tim Delaney
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160220/99ad3d8d/attachment.html>