[PATCH 3 of 3] localrepo: move new repo requirements into standalone function (API)

Gregory Szorc gregory.szorc at gmail.com
Sat Feb 20 12:00:37 EST 2016



> On Feb 19, 2016, at 04:49, Yuya Nishihara <yuya at tcha.org> wrote:
> 
>> On Mon, 15 Feb 2016 13:32:33 -0800, Gregory Szorc wrote:
>> # HG changeset patch
>> # User Gregory Szorc <gregory.szorc at gmail.com>
>> # Date 1455571220 28800
>> #      Mon Feb 15 13:20:20 2016 -0800
>> # Node ID 3d3dd48003bf005a1e8ebe3b60cd926505a3da9e
>> # Parent  87d2d6947b2f47d6812151ce667918804876d077
>> localrepo: move new repo requirements into standalone function (API)
> 
> The code looks cleaner. Queued for the clowncopter, thanks.
> 
>> +                self.requirements = newreporequirements(self)
> 
> Can we avoid passing a repo object that isn't fully initialized? Or is that
> necessary for future extension?

I use it in the RFC series for in-place-upgrade. I too wish we had a better hook point for repo creation :/


More information about the Mercurial-devel mailing list