[PATCH 1 of 3 V2] serve: rename --daemon-pipefds to --daemon-postexec

David Soria Parra dsp at experimentalworks.net
Mon Feb 22 13:39:33 EST 2016


On Mon, Feb 22, 2016 at 05:59:07PM +0000, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1456160348 0
> #      Mon Feb 22 16:59:08 2016 +0000
> # Node ID ce768a82f084d15b30acc0e44add463c0ec18587
> # Parent  28e1694ca60056d609ae2c8e0ad5cb2891416ea3
> serve: rename --daemon-pipefds to --daemon-postexec

> diff --git a/mercurial/commands.py b/mercurial/commands.py
> --- a/mercurial/commands.py
> +++ b/mercurial/commands.py
> @@ -6206,7 +6206,7 @@
>      [('A', 'accesslog', '', _('name of access log file to write to'),
>       _('FILE')),
>      ('d', 'daemon', None, _('run server in background')),
> -    ('', 'daemon-pipefds', '', _('used internally by daemon mode'), _('FILE')),
> +    ('', 'daemon-postexec', '', _('used internally by daemon mode')),
>      ('E', 'errorlog', '', _('name of error log file to write to'), _('FILE')),
>      # use string type, then we can check if something was passed
>      ('p', 'port', '', _('port to listen on (default: 8000)'), _('PORT')),

This is a BC break. We might not care as it's use internally, but I am not sure if other
libraries talking to the daemon through that interface are usign this option.

I'd recommend to leave --daemon-pipefds as a deprecated option and map it to postexec
in case the latter one doesn't exist, instead of risking breaking people, but that's
just my 2cents.




More information about the Mercurial-devel mailing list