[PATCH 7 of 7 clowncopter] automv: switch to specifying the similarity as an integer (0-100)

Augie Fackler raf at durin42.com
Mon Feb 22 17:58:35 EST 2016


On Mon, Feb 15, 2016 at 05:25:01PM +0000, Martijn Pieters wrote:
> # HG changeset patch
> # User Martijn Pieters <mjpieters at fb.com>
> # Date 1455557082 0
> #      Mon Feb 15 17:24:42 2016 +0000
> # Node ID d63407a4948f5a9ef8ddcdb077546c889dc4ce07
> # Parent  4a57546044d26cc4b2725d404ee60a11ccba3cf9
> automv: switch to specifying the similarity as an integer (0-100).

FYI, both for you and other reviewers: this patch missed some fixes to
test-automv.t. I've pushed a fix to the clowncopter (replaced two
instances of 0.6 with 60).

>
> This is consistent with the addremove --similarity option.
>
> diff --git a/hgext/automv.py b/hgext/automv.py
> --- a/hgext/automv.py
> +++ b/hgext/automv.py
> @@ -10,7 +10,8 @@
>  comes from an unrecorded mv.
>
>  The threshold at which a file is considered a move can be set with the
> -``automv.similarity`` config option; the default value is 1.00.
> +``automv.similarity`` config option. This option takes a percentage between 0
> +(disabled) and 100 (files must be identical), the default is 100.
>
>  """
>  from __future__ import absolute_import
> @@ -36,11 +37,12 @@
>      renames = None
>      disabled = opts.pop('no_automv', False)
>      if not disabled:
> -        threshold = float(ui.config('automv', 'similarity', '1.00'))
> +        threshold = float(ui.config('automv', 'similarity', '100'))
>          if threshold > 0:
>              match = scmutil.match(repo[None], pats, opts)
>              added, removed = _interestingfiles(repo, match)
> -            renames = _findrenames(repo, match, added, removed, threshold)
> +            renames = _findrenames(repo, match, added, removed,
> +                                   threshold / 100.0)
>
>      with repo.wlock():
>          if renames is not None:
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list