[PATCH 3 of 3] graphmod: use different styles for different edge types

Tim Delaney timothy.c.delaney at gmail.com
Wed Feb 24 14:31:15 EST 2016


On 25 February 2016 at 03:22, Martijn Pieters <mj at zopatista.com> wrote:

> On 23 February 2016 at 20:30, Tim Delaney <timothy.c.delaney at gmail.com>
> wrote:
> > I don't know if it's feasible with the current graphing code (I suspect
> > not), but it might also be nice if we could trim lines that would
> continue
> > past the end of the graph (and indicate that with an *) e.g.
>
> Sorry, my example was trimmed. `:` is a grandfather line, and *does*
> reach a node. I'm going to hack the graphing code to do what you
> proposed though, which is what my proposal is about. Instead of `*` I
> proposed `~` after a short solid line. `*` is too 'round', it could be
> used for nodes instead (like `o` and `@` and `x` are already).
>

Maybe I've misunderstood the terminology here - due to our timezones, I
always read your emails before I've had any caffeine for the day ;)
Thinking about it more, I think this is what you mean:

Grandparent line: a line which skips one or more parent revisions, but
still joins up to something on the current graph.

Non-parent line: a line which extends past the end of the current graph.

If that's right, then yes, we're both talking about the second case.

To me ~ looks like a terminator (similar to - for a closed branch) and I
suspect that had to do with my misunderstanding. I like * as it has
symmetry with globbing - it's saying there's more to the line that we're
not explicitly spelling out.

But anyway, I'm not implementing it - go with your gut.

Tim Delaney
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160225/1bed5c5f/attachment.html>


More information about the Mercurial-devel mailing list