[PATCH] run-tests: report path for tests outside current directory

timeless timeless at gmail.com
Thu Feb 25 15:27:35 EST 2016


On Thu, Feb 25, 2016 at 3:21 PM, timeless <timeless at mozdev.org> wrote:
>
> @@ -1640,6 +1645,7 @@
>  # newest.
>
>  def loadtimes(testdir):
> +    # This should only deal with times for tests in testdir
>      times = []
>      try:
>          with open(os.path.join(testdir, '.testtimes-')) as fp:
> @@ -1652,6 +1658,7 @@
>      return times
>
>  def savetimes(testdir, result):
> +    # This should only deal with times for tests in testdir
>      saved = dict(loadtimes(testdir))
>      maxruns = 5
>      skipped = set([str(t[0]) for t in result.skipped])

These hunks are a todo which shouldn't really be included in this commit.

Basically if you have:
test-foo.t
bar/test-foo.t

Then timings for the latter will stomp on the former, which is almost
certainly not wanted.
There's a similar problem w/ xunit reporting.


More information about the Mercurial-devel mailing list