[PATCH 5 of 5] chgserver: make _renewui load repo and command line configs

[Yuya Nishihara]

On Thu, 25 Feb 2016 16:42:17 +0000, Jun Wu wrote:
> -- PATCH 1 --
> > Let's start with ['extensions']. The other sections would need
> > detailed comments. It's easy to add sections, but hard to remove
> > them from the list.
> 
> I think it's easy to remove them too, we are free to change the hash
> function.

I meant we would have to be more careful not to break things. Imagine that
you have to clean up demandimport.ignore list, can you be confident?

> > Missing '$' at the end? re.match() passes if a string starts with
> > the pattern, but you seem to expect an exact match.
> 
> Thanks for pointing out! The Python behavior here seems a bit strange to
> me though. I'm much more familiar with Ruby than Python.

IIRC, Ruby has no function equivalent to re.match(), but has re.search().

> > configitems() have a stable order. IIRC, we can't be 100% sure that
> > the loading order of extensions never change the behavior.
> 
> I see it's util.sortdict, like Ruby's Hash. Will remove sorted.
> 
> But extensions should behavior the same no matter of the loading order,
> right? I thought otherwise they are required to touch extensions._order
> or _aftercallbacks.

Yep. There were a couple of bugs in old versions.