[PATCH 5 of 6 RFC] destutil: show number of other branch heads, even if on a closed head

[Pierre-Yves David]

On 02/25/2016 07:48 PM, FUJIWARA Katsunori wrote:
>
> At Thu, 25 Feb 2016 00:16:04 +0100,
> Pierre-Yves David wrote:
>>
>> On 02/24/2016 03:17 PM, FUJIWARA Katsunori wrote:
>>> # HG changeset patch
>>> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
>>> # Date 1456322433 -32400
>>> #      Wed Feb 24 23:00:33 2016 +0900
>>> # Node ID 1f9b3d38e380b018cbe10ed1acee882c014e3763
>>> # Parent  54683cfda6e09c5502ad133d5a023929531a6b8b
>>> destutil: show number of other branch heads, even if on a closed head
>>>
>>> Before this patch, bare "hg update" doesn't show number of other
>>> non-closed branch heads, if working parent is on a closed branch head
>>> at the end of updating. This might mislead user into overlooking other
>>> non-closed branch heads.
>>>
>>> This patch gets a list of all branch heads regardless of closed-ness
>>> of it, and uses it to examine whether working parent is on a branch
>>> heads or not.
>>
>> closed head should mostly disapear from the UI. I personnaly don't think
>> this is a move in the right direction to include them in this warning again.
>>
>> I'm unclear about your sentence:
>>
>>   > if working parent is on a closed branch head
>>   > at the end of updating. This might mislead user into overlooking other
>>   > non-closed branch heads.
>>
>> Can you elaborate on this scenario. What's happening, what is printed
>> and why is this confusing for the user?
>
> Main concern of this patch is not "count also closed heads as other
> heads", but "show message about other branch heads even if parent is
> on a closed head".
>
> What about revised patch description below ?

I'm either much more awake or this is much clearer. I've updated the 
description and pushed the result to the clowncopter.

Thanks.

Lets chat about patch 6 now ;-)

-- 
Pierre-Yves David