[PATCH 2 of 1] changegroup: progress for added files is not measured in "chunks"

Anton Shestakov engored at ya.ru
Mon Feb 29 16:53:33 UTC 2016


29.02.2016, 15:00, "Martin von Zweigbergk" <martinvonz at google.com>:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1456728667 28800
> # Sun Feb 28 22:51:07 2016 -0800
> # Node ID 58e2277b2be71c0bc92cbe2f790017bfa2a74ff0
> # Parent 37f0bbe9fd420eff5487aaa5e499a34f1fa9c902
> changegroup: progress for added files is not measured in "chunks"
>
> The "prog" class cg1unpacker.apply() has the unit set to
> "chunks". This is not correct for files; for files, we should not show
> any unit at all.

Unfortunately, unit is also used in 'speed' entry, and if it's not set, then speed is measured in <nothing>/sec, which doesn't look right.

> The unit is not usually printed, which is probably
> why this has not been fixed yet. It can be show with e.g. "--config
> progress.format='topic number unit'".

I'm using:

format = topic bar number item speed estimate

And this is what I saw with this patch:

files [===> ] 331/2364 70 /sec 29s

Speed here is "70 /sec".


More information about the Mercurial-devel mailing list