[PATCH 2 of 2 pager] pager: use absolute_import

Gregory Szorc gregory.szorc at gmail.com
Mon Feb 29 16:10:37 EST 2016



> On Feb 29, 2016, at 10:15, Augie Fackler <raf at durin42.com> wrote:
> 
> # HG changeset patch
> # User Augie Fackler <augie at google.com>
> # Date 1456715700 18000
> #      Sun Feb 28 22:15:00 2016 -0500
> # Node ID a60719c394344517426b0a35f8b54f4c34eed5f6
> # Parent  e74833e8ebe905296eed4ac8a83c2812c2426d34
> # EXP-Topic pager
> pager: use absolute_import
> 
> diff --git a/hgext/pager.py b/hgext/pager.py
> --- a/hgext/pager.py
> +++ b/hgext/pager.py
> @@ -58,9 +58,16 @@ you can use --pager=<value>::
>   will also work).
> 
> '''
> +from __future__ import absolute_import
> 
> import atexit, sys, os, signal, subprocess

These should be on separate lines. Does a test not complain?

> -from mercurial import commands, dispatch, util, extensions, cmdutil
> +from mercurial import (
> +    cmdutil,
> +    commands,
> +    dispatch,
> +    extensions,
> +    util,
> +    )
> from mercurial.i18n import _
> 
> # Note for extension authors: ONLY specify testedwith = 'internal' for
> diff --git a/tests/test-check-py3-compat.t b/tests/test-check-py3-compat.t
> --- a/tests/test-check-py3-compat.t
> +++ b/tests/test-check-py3-compat.t
> @@ -73,7 +73,6 @@
>   hgext/largefiles/wirestore.py not using absolute_import
>   hgext/mq.py not using absolute_import
>   hgext/notify.py not using absolute_import
> -  hgext/pager.py not using absolute_import
>   hgext/patchbomb.py not using absolute_import
>   hgext/purge.py not using absolute_import
>   hgext/rebase.py not using absolute_import
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list