[1 of 3]Fixing Import Cycles.

[timeless]

Please don't use comic sans (or whatever font you're using).
please use plain text.

On Mon, Feb 29, 2016 at 3:29 PM, Pulkit Goyal <7895pulkit at gmail.com> wrote:
> Hello Everyone,
>
> I was working on fixing import cycles in the codebase. The first import
> cycle was between hgext/largefiles/basestore and
> hgext/largefiles/localstore. The dependency can be solved by resolving the
> dependency of localstore on basestore. The dependency was of StoreError
> class which was required in the both the files but the only reason to import
> basestore in localstore.
>
> So rather we define the StoreError class in localstore rather than
> basestore. Its necessary to import localstore in basestore. So this is the
> only way around. I guess.
>
> Well now I feel like i going on the right track but still I doubt. After
> running hg locate 'mercurial/**.py' 'hgext/**.py' | sed 's-\\-/-g' | python
> "$import_checker" - I was getting new import cycles so I think i fixed this
> one.
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>