[PATCH] test-bundle2-format.t: force gc so a GeneratorExit will be thrown

Bryan O'Sullivan bos at serpentine.com
Fri Jan 1 18:51:55 UTC 2016


On Tue, Dec 29, 2015 at 2:55 PM, Augie Fackler <raf at durin42.com> wrote:

> I'm a little weirded out by this fix, because it worries me that it is
> going to choke us in weird ways in production. Can you allay that fear at
> all?
>

I don't think it's really the right fix myself – we need something more
deterministic than relying on the refcount dropping to zero or the gc
running.

Along those lines, do we have an opinion on the use of "with" vs
"try/finally" now that we're in 2.6 land? There seem to be no uses of
"with" yet in the codebase, but it would be useful to standardise on one
mechanism. The big advantage of "with" is that with a bit of hacking, we
can collapse what would otherwise have to be nested try/finally blocks into
one.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20160101/344854a3/attachment.html>


More information about the Mercurial-devel mailing list