[PATCH 2 of 6 lazymanifest-errors] lazymanifest: check another error return in delitem
Bryan O'Sullivan
bos at serpentine.com
Fri Jan 1 22:53:38 UTC 2016
On Thu, Dec 31, 2015 at 11:05 AM, Augie Fackler <raf at durin42.com> wrote:
> needle.start = PyString_AsString(key);
> + if (!needle.start) {
> + return -1;
> + }
>
This check is unnecessary as you've already done a PyString_Check a few
lines earlier.
In fact you can and should use PyString_AS_STRING for efficiency here
instead.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20160101/5e195bbc/attachment.html>
More information about the Mercurial-devel
mailing list