[PATCH 5 of 6 V7] dirstate: add a C implementation for nonnormalentries

Bryan O'Sullivan bos at serpentine.com
Sat Jan 2 00:58:00 UTC 2016


On Wed, Dec 23, 2015 at 1:20 PM, Laurent Charignon <lcharignon at fb.com>
wrote:

> +       if (!PyArg_ParseTuple(args, "O!:nonnormalentries",
> +                             &PyDict_Type, &dmap))
> +               goto bail;
> +
> +       nonnset = PySet_New(NULL);
> +       if (nonnset == NULL)
> +               goto bail;
>

We normally reserve "goto bail" for cases where there's cleanup needed. In
these two cases there's no cleanup required, so it's clearer to simply
"return NULL".
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20160101/38780d26/attachment.html>


More information about the Mercurial-devel mailing list