[PATCH 1 of 2] revlog: return offset from _chunkraw()

Martin von Zweigbergk martinvonz at google.com
Tue Jan 5 22:52:43 CST 2016


On Tue, Jan 5, 2016 at 8:47 PM Gregory Szorc <gregory.szorc at gmail.com>
wrote:

> On Tue, Jan 5, 2016 at 8:39 PM, Martin von Zweigbergk <
> martinvonz at google.com> wrote:
>
>>
>>
>> On Tue, Jan 5, 2016 at 7:52 PM Gregory Szorc <gregory.szorc at gmail.com>
>> wrote:
>>
>>> +        Callers will need to call ``self.start(rev)`` and
>>> ``self.length(rev)``
>>> +        to determine where each revision's data begins and ends.
>>
>>
>> Is that still true? Is the returned offset/start different from
>> self.start(rev)?
>>
>
> The function returns data for 1 or more revisions. The first revision will
> have offset == self.start(rev), so you don't need to call anything if you
> are only getting a single revision.
>

I see. Will test and push to the clowncopter soon. Thanks for cleaning up!
And great commit message on the next patch. I'm glad someone seems to
remember the (obsolete) reason for it. I would probably have given up
trying to understand that piece of code.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20160106/1966b195/attachment.html>


More information about the Mercurial-devel mailing list