[PATCH] tests: make test-check-code.t work with lz4revlog repositories

[Martin von Zweigbergk]

On Wed, Jan 6, 2016 at 1:45 PM Laurent Charignon <lcharignon at fb.com> wrote:

> On Jan 6, 2016, at 1:39 PM, Martin von Zweigbergk <martinvonz at google.com>
> wrote:
>
> I would not expect our tests to work on other projects, and it seems
> unfortunate to include knowledge of a specific other project (lz4revlog) in
> hg core, even though the other project may be related to hg.
>
>
> Ok, I will find another way to make it work...
>

If the goal was to be able to use extensions that add requirements on an hg
core clone, I would be more open to it. Let's say you were instead using
lz4revlog on hg core, would tests fail then? I can imagine they would since
your ~/.hgrc is not read (right?). Perhaps the test runner could export a
ORIG_HOME or so pointing to your ~ and we could do 'HOME="$ORIG_HOME" hg
locate'? I don't know if we care enough about enabling extensions on hg
core repos that we want to complicate our tests, though. What do you think?
Others?


>
>
> On Wed, Jan 6, 2016, 13:34 Laurent Charignon <lcharignon at fb.com> wrote:
>
>> On Jan 6, 2016, at 1:28 PM, Martin von Zweigbergk <martinvonz at google.com>
>> wrote:
>>
>>
>>
>> On Wed, Jan 6, 2016 at 1:00 PM Laurent Charignon <lcharignon at fb.com>
>> wrote:
>>
>>> # HG changeset patch
>>> # User Laurent Charignon <lcharignon at fb.com>
>>> # Date 1452113953 28800
>>> #      Wed Jan 06 12:59:13 2016 -0800
>>> # Node ID 11457f74b5e9522c2b863b332656c891133202ea
>>> # Parent  b8405d739149cdd6d8d9bd5e3dd2ad8487b1f09a
>>> tests: make test-check-code.t work with lz4revlog repositories
>>>
>>> Before this patch 'hg locate' would fail on repositories with lz4revlog.
>>> This makes test-check-code.t more reusable for other repositories and
>>> make it
>>> work for clones of the repository that use lz4revlog.
>>
>>
>> I don't follow. Are you running test-check-code.t in a clone of hg with
>> lz4revlog enabled? How about test-check-execute.t and others that run 'hg
>> files', why don't they also fail?
>>
>>
>>
>> I was running test-check-code on other repos (not hg core) and I ran into
>> this issue.
>> I have not run all the tests against an lz4revlog enabled clone of hg.
>>
>> Thanks,
>>
>> Laurent
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20160106/470884cd/attachment.html>