[PATCH] tests: make test-check-code.t work with lz4revlog repositories

[Martin von Zweigbergk]

On Wed, Jan 6, 2016 at 1:57 PM Durham Goode <durham at fb.com> wrote:

>
>
> On 1/6/16 1:52 PM, Martin von Zweigbergk wrote:
>
> On Wed, Jan 6, 2016 at 1:45 PM Laurent Charignon <lcharignon at fb.com>
> wrote:
>
>> On Jan 6, 2016, at 1:39 PM, Martin von Zweigbergk <martinvonz at google.com>
>> wrote:
>>
>> I would not expect our tests to work on other projects, and it seems
>> unfortunate to include knowledge of a specific other project (lz4revlog) in
>> hg core, even though the other project may be related to hg.
>>
>>
>> Ok, I will find another way to make it work...
>>
>
> If the goal was to be able to use extensions that add requirements on an
> hg core clone, I would be more open to it. Let's say you were instead using
> lz4revlog on hg core, would tests fail then? I can imagine they would since
> your ~/.hgrc is not read (right?). Perhaps the test runner could export a
> ORIG_HOME or so pointing to your ~ and we could do 'HOME="$ORIG_HOME" hg
> locate'? I don't know if we care enough about enabling extensions on hg
> core repos that we want to complicate our tests, though. What do you think?
> Others?
>
>
> Yes, this applies to hg core too.  If hg core is cloned with lz4, all of
> the test-check-* tests fail because they run hg with all extensions
> disabled (which is desirable for the actual test invocations, since it
> means they are consistent regardless of system settings).
>
> Maybe we can add a hg_sys command that is available inside the test suite
> and allows us to run the normal system Mercurial without all the configs
> disabled?
>

Sounds good to me. I would not mind patches for that whenever you guys have
time.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20160106/3c47b43b/attachment.html>