[PATCH 3 of 3] tests: extend check-commit self-tests

Augie Fackler raf at durin42.com
Sun Jan 10 19:29:01 CST 2016


> On Jan 10, 2016, at 8:13 PM, Matt Mackall <mpm at selenic.com> wrote:
> 
> On Sat, 2016-01-09 at 00:21 -0500, Augie Fackler wrote:
>>> On Jan 8, 2016, at 1:46 PM, Matt Mackall <mpm at selenic.com> wrote:
>>> 
>>> # HG changeset patch
>>> # User Matt Mackall <mpm at selenic.com>
>>> # Date 1452276435 21600
>>> #      Fri Jan 08 12:07:15 2016 -0600
>>> # Node ID a8ea9d699407fcbdb44c87a097f32432039ca483
>>> # Parent  54875580a56db3682f5dc4cadd65c7b6d9176cd7
>>> tests: extend check-commit self-tests
>> 
>> 1 and 2 are clowncopterized, but 3 fails tests for me. Can you take a look and
>> resend?
> 
> Still works for me after rebasing, you'll need to be more specific.

--- /home/augie/hg/tests/test-check-commit.t
+++ /home/augie/hg/tests/test-check-commit.t.err
@@ -20,5 +20,14 @@
   >        echo
   >   fi
   > done
+  Revision a7324f739d78 does not comply to rules
+  ------------------------------------------------------
+  57: (BC) needs to be uppercase
+   +  > transplant/foo: this summary is way too long use Oxford comma (bc) (bug123) (issue 244)
+  57: no space allowed between issue and number
+   +  > transplant/foo: this summary is way too long use Oxford comma (bc) (bug123) (issue 244)
+  57: use (issueDDDD) instead of bug
+   +  > transplant/foo: this summary is way too long use Oxford comma (bc) (bug123) (issue 244)
+

That’s on the GCC compile farm.


> Is your patch flow swallowing trailing spaces?

I sincerely doubt that - many things would have been broken for years were that the case. Generally patches won’t even apply if there’s trailing whitespace damage.

> 
> --
> Mathematics is the supreme nostalgia of our time.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20160110/5fb13c64/attachment.pgp>


More information about the Mercurial-devel mailing list