[PATCH 3 of 3] tests: extend check-commit self-tests

[Matt Mackall]

On Sun, 2016-01-10 at 20:29 -0500, Augie Fackler wrote:
> > On Jan 10, 2016, at 8:13 PM, Matt Mackall <mpm at selenic.com> wrote:
> > 
> > On Sat, 2016-01-09 at 00:21 -0500, Augie Fackler wrote:
> > > > On Jan 8, 2016, at 1:46 PM, Matt Mackall <mpm at selenic.com> wrote:
> > > > 
> > > > # HG changeset patch
> > > > # User Matt Mackall <mpm at selenic.com>
> > > > # Date 1452276435 21600
> > > > #      Fri Jan 08 12:07:15 2016 -0600
> > > > # Node ID a8ea9d699407fcbdb44c87a097f32432039ca483
> > > > # Parent  54875580a56db3682f5dc4cadd65c7b6d9176cd7
> > > > tests: extend check-commit self-tests
> > > 
> > > 1 and 2 are clowncopterized, but 3 fails tests for me. Can you take a look
> > > and
> > > resend?
> > 
> > Still works for me after rebasing, you'll need to be more specific.
> 
> --- /home/augie/hg/tests/test-check-commit.t
> +++ /home/augie/hg/tests/test-check-commit.t.err
> @@ -20,5 +20,14 @@
>    >        echo
>    >   fi
>    > done
> +  Revision a7324f739d78 does not comply to rules
> +  ------------------------------------------------------
> +  57: (BC) needs to be uppercase
> +   +  > transplant/foo: this summary is way too long use Oxford comma (bc)
> (bug123) (issue 244)
> +  57: no space allowed between issue and number
> +   +  > transplant/foo: this summary is way too long use Oxford comma (bc)
> (bug123) (issue 244)
> +  57: use (issueDDDD) instead of bug
> +   +  > transplant/foo: this summary is way too long use Oxford comma (bc)
> (bug123) (issue 244)

Ahh. These are all false positives: it's running check-commit on your draft
commits and finding intentionally bad jargon in the body of a commit that's
testing detection of said jargon. They weren't triggering for me because my
local csets were secret.

Short of introducing a no-check-commit mechanism or a way of putting escaping in
run-test commands, there's no simple fix. On the other hand, it'll cease to be
an issue as soon as the change is marked public.

-- 
Mathematics is the supreme nostalgia of our time.