[PATCH 2 of 8] children: update help with replacement

Matt Harbison mharbison72 at gmail.com
Mon Jan 11 21:23:32 CST 2016


On Mon, 11 Jan 2016 22:11:57 -0500, Siddharth Agarwal  
<sid at less-broken.com> wrote:

> On 1/11/16 16:52, Matt Harbison wrote:
>> We should probably use double quotes (even though I understand the  
>> point in the next patch that it can look weird), because cmd.exe  
>> doesn't understand single quotes:
>>
>>   C:\Users\Matt\Projects\hg>hg log -r 'children()'
>>   abort: unknown revision 'children()'!
>
> Yeah. What about doing it the other way round? Ban
>
> "hg log "foo bar""
>
> and
>
> "hg log 'foo bar'"
>
> but allow
>
> 'hg log "foo bar"'
>
> Not perfect, but it'll work I guess.

It seems from the 3 of 8 patch that something is translating '`' -> '"',  
so there might be more than banning one form involved?  But the help  
generation is still magic to me.

I think single quotes on the outside is reasonable, barring some technical  
issue.

>>
>> It works fine in MSYS, but I suspect that most Windows users that copy  
>> help examples will be using cmd.exe, and not understand quote vs double  
>> quote.
>>
>> This applies to the next two patches as well.  It hasn't stood out to  
>> me before, so I'm not sure how much has been converted (or added)  
>> already with your previous work on help stuff.


More information about the Mercurial-devel mailing list