[PATCH 2 of 2] changegroup: remove now-unused 'wasempty' variable and parameter

[Martin von Zweigbergk]

On Tue, Jan 12, 2016 at 8:35 AM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
>
>
>> On Jan 12, 2016, at 07:31, Augie Fackler <raf at durin42.com> wrote:
>>
>> On Tue, Jan 12, 2016 at 10:28 AM, Martin von Zweigbergk
>> <martinvonz at google.com> wrote:
>>> Greg has some comments on patch 1. He suggested introducing a new bundle
>>> type. If you are with that, could you dequeue these two and queue my cg4
>>> patches instead of they look good to you?
>>
>> What I took away from that discussion was that we probably need to put
>> the required part parameters in the bundle params bit for
>> clonebundles, not that we need to bump the bundle format. Am I wrong
>> about that?
>
> I need to think about it. We probably should add some forward compat here. I also like "v1" "v2" etc denoting strong, unchanging semantics.
>
> I think we should hold off declaring the new bundle type for cg3/cg4 until the feature set stabilizes, which it apparently is still doing.

Even if we define a new bundle type, perhaps this patch series is the
right way of getting the treemanifest requirement across to the
client, so we can update the repo requirement (as I did in patch 1)?
I.e. leave this queued until we decide on cg3/cg4 and the bundle spec
stuff?