[PATCH 1 of 6] check-code: export needs a space so avoid false possitives
timeless
timeless at mozdev.org
Tue Jan 12 18:38:04 UTC 2016
# HG changeset patch
# User timeless <timeless at mozdev.org>
# Date 1452614339 0
# Tue Jan 12 15:58:59 2016 +0000
# Node ID 13f44adf400886e8d65fcb2bcf5dc5763b250214
# Parent edd2615ad226c14f6904fc1738c3dc36431db223
check-code: export needs a space so avoid false possitives
diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -107,7 +107,7 @@
"use egrep for extended grep syntax"),
(r'/bin/', "don't use explicit paths for tools"),
(r'[^\n]\Z', "no trailing newline"),
- (r'export.*=', "don't export and assign at once"),
+ (r'export .*=', "don't export and assign at once"),
(r'^source\b', "don't use 'source', use '.'"),
(r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
(r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
More information about the Mercurial-devel
mailing list