[PATCH] run-tests: skip threading for a single test (issue5040)

[Matt Harbison]

On Thu, 14 Jan 2016 14:35:27 -0500, timeless <timeless at gmail.com> wrote:

> So, the code fix is right. We're trying to sort out a test to avoid
> regressing this stuff in the future.
>
> I'm away until Wednesday, I'd favor just queuing the fix with a note  
> that a
> test should follow.

I'm good with queuing the fix and dropping the test for now too.

> On Jan 14, 2016 2:05 PM, "Augie Fackler" <raf at durin42.com> wrote:
>
>> On Thu, Jan 14, 2016 at 11:41:12AM -0500, timeless wrote:
>> > Matt Harbison wrote:
>> > > I was a little surprised that `kill` was available on Windows.
>> >
>> > You're actually seeing msys bash's internal kill as opposed to
>> > kill.exe (which msys could have, but which wouldn't recognize %1 as a
>> > meaningful argument).
>> >
>> > I'm really not at all sure how portable this approach is. Especially
>> > if there are lots of wrappers creating intermediate processes...
>> >
>> > I considering trying to use ps to get parent processes, I also
>> > considered $! [1], but then decided that %1 would work well enough.
>>
>> I'm going to hold off on reviewing this until you two figure out the
>> windows bits. Please cc me or do a resend as needed once that's
>> sorted. Thanks!
>>
>> >
>> > [1]
>> http://www.gnu.org/software/bash/manual/bashref.html#Special-Parameters
>> > _______________________________________________
>> > Mercurial-devel mailing list
>> > Mercurial-devel at selenic.com
>> > https://selenic.com/mailman/listinfo/mercurial-devel