[PATCH 1 of 6] check-code: export needs a space so avoid false possitives

Yuya Nishihara yuya at tcha.org
Fri Jan 15 08:37:51 CST 2016


On Tue, 12 Jan 2016 12:38:04 -0600, timeless wrote:
> # HG changeset patch
> # User timeless <timeless at mozdev.org>
> # Date 1452614339 0
> #      Tue Jan 12 15:58:59 2016 +0000
> # Node ID 13f44adf400886e8d65fcb2bcf5dc5763b250214
> # Parent  edd2615ad226c14f6904fc1738c3dc36431db223
> check-code: export needs a space so avoid false possitives
> 
> diff --git a/contrib/check-code.py b/contrib/check-code.py
> --- a/contrib/check-code.py
> +++ b/contrib/check-code.py
> @@ -107,7 +107,7 @@
>       "use egrep for extended grep syntax"),
>      (r'/bin/', "don't use explicit paths for tools"),
>      (r'[^\n]\Z', "no trailing newline"),
> -    (r'export.*=', "don't export and assign at once"),
> +    (r'export .*=', "don't export and assign at once"),

Sure, pushed this one to the clowncopter, thanks.


More information about the Mercurial-devel mailing list