[PATCH] buildrpm: use bash shebang, since we use bash features in the script

Pierre-Yves David pierre-yves.david at ens-lyon.org
Sun Jan 17 13:52:09 CST 2016



On 01/17/2016 06:24 AM, Yuya Nishihara wrote:
> On Fri, 15 Jan 2016 09:22:45 -0600, Mathias De Maré wrote:
>> # HG changeset patch
>> # User Mathias De Maré <mathias.demare at gmail.com>
>> # Date 1452870985 -3600
>> #      Fri Jan 15 16:16:25 2016 +0100
>> # Node ID 649c3d63ce7112beb55ec4d0f77ff401eb89b97b
>> # Parent  63116d47cc3fd179c90b117397cc26341a381edb
>> buildrpm: use bash shebang, since we use bash features in the script
>>
>> As suggested by Bryan O'Sullivan.
>>
>> diff --git a/contrib/buildrpm b/contrib/buildrpm
>> --- a/contrib/buildrpm
>> +++ b/contrib/buildrpm
>> @@ -1,4 +1,4 @@
>> -#!/bin/sh -e
>> +#!/bin/bash -e
>
> Given that this script will never be run on FreeBSD, it looks good to me.
>
> (I don't queue right now as I'm lost the current state of clowncopter.)

I've it pushed to the clowncopter.

(Yep, clowncopter state is a bit messy as not all of Bryan series made 
it through).

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list