[PATCH 3 of 3] streamclone: use backgroundfilecloser (issue4889)

Adrian Buehlmann adrian at cadifra.com
Mon Jan 18 02:51:42 CST 2016


On 2016-01-18 03:44, Matt Mackall wrote:
> On Thu, 2016-01-14 at 13:45 -0800, Gregory Szorc wrote:
>> # HG changeset patch
>> # User Gregory Szorc <gregory.szorc at gmail.com>
>> # Date 1452807841 28800
>> #      Thu Jan 14 13:44:01 2016 -0800
>> # Node ID 3cc9fde87e3284c2653a25254b22f03339dbd075
>> # Parent  d73af0bac3890fd4b7b43d888ff61718a166cbdd
>> streamclone: use backgroundfilecloser (issue4889)
> 
> I've gone ahead and queued these. I've left the 2048 default low to make sure we
> maximize coverage during the freeze: please get people to test it!

I won't test it myself (I stopped playing guinea pig quite a while ago),
but I think - as I already said - that a default of 2048 is way too low.

This patch tries to "fix" a problem which does not exist for such small
numbers of files. The potential problems it may introduce are however
now inflicted on many users - due to the small default. On a platform,
which is already shaky enough (Windows).


More information about the Mercurial-devel mailing list